topology2: cavs-cs42l43: Add topology for cs42l43/cs35l56 on MTL #8773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrozek
requested review from
charleskeepax,
plbossart,
rfvirgil,
simontrimmer,
bardliao and
lgirdwood
bardliao
reviewed
Jan 23, 2024
|
Corresponding mtl-match.c file change: https://lore.kernel.org/lkml/20240123113246.75539-1-mstrozek@opensource.cirrus.com/T/#u |
plbossart
requested changes
Jan 23, 2024
| @@ -32,6 +32,12 @@ NUM_HDMIS=0,SDW_SPK_STREAM=Playback-SmartAmp,SDW_SPK_IN_STREAM=Capture-SmartAmp, | |||
| SDW_DMIC_STREAM=Capture-SmartMic,SDW_JACK_OUT_STREAM=Playback-SimpleJack,\ | |||
| SDW_JACK_IN_STREAM=Capture-SimpleJack,SDW_AMP_FMT_24=true,SDW_JACK_FMT_24=true" | |||
|
|
|||
| "cavs-sdw\;sof-mtl-cs42l43-l0-cs35l56-l23\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=2,SDW_DMIC=1,\ | |||
| NUM_HDMIS=0,SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,\ | |||
There was a problem hiding this comment.
please remove NUM_HDMIS=0, this is no longer needed.
There was a problem hiding this comment.
we also need to fix line 31 @bardliao, NUM_HDMI=0 is a leftover we need to clean-up
There was a problem hiding this comment.
mstrozek
force-pushed
the
mstrozek/mtl
branch
from
a7a2ff8
to
284b20e
Compare
plbossart
reviewed
Jan 24, 2024
plbossart
reviewed
Jan 24, 2024
|
The CS35L56 has feedback but it is currently only used for debug. As it isn't currently needed in production it seems safer to leave it off for now. We could turn it on in future. There is no need to remove the feedback from sof-mtl-cs42l43-l0-cs35l56-l12. That is for the EIGHT-C/AIC board, right? Which is a development system so debugging is useful. |
The layout is configured as:
- Link0: CS42L43 Jack and mics
- Link2: 2x CS35L56 Speaker (amps 3 and 4, right)
- Link3: 2x CS35L56 Speaker (amps 1 and 2, left)
Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
mstrozek
force-pushed
the
mstrozek/mtl
branch
from
284b20e
to
8d988ab
Compare
bardliao
approved these changes
Jan 25, 2024
plbossart
approved these changes
Jan 25, 2024
roxell
pushed a commit
to roxell/linux
that referenced
this pull request
Jan 31, 2024
The layout is configured as: - Link0: CS42L43 Jack and mics (2ch) - Link2: 2x CS35L56 Speaker (amps 3 and 4, right) - Link3: 2x CS35L56 Speaker (amps 1 and 2, left) Corresponding SOF topology: thesofproject/sof#8773 Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com> Link: https://msgid.link/r/20240123113246.75539-1-mstrozek@opensource.cirrus.com Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout is configured as:
- Link0: CS42L43 Jack and mics
- Link2: 2x CS35L56 Speaker (amps 3 and 4, right)
- Link3: 2x CS35L56 Speaker (amps 1 and 2, left)