Skip to content
This repository has been archived by the owner on Jan 17, 2019. It is now read-only.

default_hw_conf_id should not be set to 0 #15

Closed
xiulipan opened this issue Jun 29, 2018 · 1 comment
Closed

default_hw_conf_id should not be set to 0 #15

xiulipan opened this issue Jun 29, 2018 · 1 comment

Comments

@xiulipan
Copy link
Contributor

default_hw_conf_id should be the id that in the configs list.
Be 0 will let most hw_config not set in function
static void set_link_hw_format(struct snd_soc_dai_link *link, struct snd_soc_tplg_link_config *cfg)
https://github.com/thesofproject/linux/blob/cb05347d9f85e18b414098d512c8287c297933d2/sound/soc/soc-topology.c#L2015
keyonjie added a commit to keyonjie/soft that referenced this issue Jun 29, 2018
@keyonjie
Revert "topology: dai: correct default_hw_conf_id"
f359214 
This reverts commit 229da95 which call
regression:
thesofproject#15

Default_hw_conf_id is id, not index of array, revert to fix it.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@keyonjie keyonjie mentioned this issue Jun 29, 2018
Merged
@keqiaozhang
Copy link
Collaborator

This issue is fixed by #16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgirdwood @keqiaozhang @xiulipan