Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependencies on Buffer (#24) #30

Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix: remove dependencies on Buffer (#24) #30

merged 1 commit into from
Jan 15, 2020

Conversation

avbentem
Copy link
Contributor

Fixes #24 (the EcmaScript 5 in TTN Payload Formats do not support Buffer), and gets rid of:

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 98.909% when pulling 17410ac on avbentem:master into 6c4d356 on thesolarnomad:master.

@avbentem
Copy link
Contributor Author

Oh well, I guess that decreasing the lines of code also made the coverage drop by a whopping 0.02% :-)

@joscha
Copy link
Member

joscha commented Jan 15, 2020

Thanks!

@joscha joscha merged commit 4ced493 into thesolarnomad:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTN Encoder and Payload Format
3 participants