Added getLength() #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscha
reviewed
Oct 8, 2022
src/LoraEncoder.cpp
Outdated
| _buffer += 8; | ||
| _intToBytes(_buffer + _offset, lat, 4); | ||
| _intToBytes(_buffer + _offset + 4, lng, 4); | ||
| _offset += 8; |
There was a problem hiding this comment.
I am wondering if it would be more logical to split this up in two += 4 parts?
Or if it would even make sense to express all of these as:
_buffer + (_offset += ...) where the advancement is inlined.
What do you think?
There was a problem hiding this comment.
Yes, following your first proposal should improve readability.
joscha
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I downloaded the fork and ran the tests. It seems I did not break anything. ;-)