Added pinterest support, facebook share dialog, google snippets, reactivity #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 20, 2015 23:07
Added pinterest support. Modified api so that users have control over order and size of social icons. Loop to reduce code duplication.
Facebook now uses share dialog when there's a valid app_id Changed sites array to an object for future configurations Pattern match test instead of comparing for possible port changes
Extended site configuration Added explicit site order array Added reactivity when data context changes
Doc is intentionally left incomplete for less conflicts when changes will be merged back.
Silence that annoying fb-root warning
|
@queso You should merge this in 👍 |
|
@rgoomar have you tested it in an app yet? |
|
Not just yet, but from going through the code, the logic seems to be in place and I don't see why it should break anything really. I can test it later tonight though. |
|
That would be awesome, my main focus is velocity atm and I will be wrapped up in that all night. |
|
+1 |
queso
added a commit
that referenced
this pull request
Feb 27, 2015
Added pinterest support, facebook share dialog, google snippets, reactivity
|
Need to add to the README that init is now explicitly required. Plus googleplus color is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Let me know what you think works and what doesn't. Thanks :)