Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some tests use signed long instead of int32_t causing issues on 64-bit systems #420

Closed
giuliomoro opened this issue Feb 2, 2024 · 0 comments · Fixed by #421
Closed

some tests use signed long instead of int32_t causing issues on 64-bit systems #420

giuliomoro opened this issue Feb 2, 2024 · 0 comments · Fixed by #421

Comments

@giuliomoro
Copy link
Contributor

Idioms such as:

typedef long int MY_TYPE;
#define FORMAT RTAUDIO_SINT32

become problematic on 64-bit systems, or more in general wherever long int is not 32 bits.

There are two instances of this in tests/duplex.cpp and tests/playsaw.cpp and tests/record.cpp, but they were commented out, so wouldn't get caught by tests. Other tests use signed int instead which may be OK, but I'd suggest to have all the types be explicit using fixed-width integers from stdint.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant