Fix WASAPI shutdown crash

[MarcusTomlinson]

No description provided.

[garyscavone]

Hi Marcus,

I tested the WASAPI code and the updated sample rate support seems fine. However, while duplex operation is working, audio input only does not seem to work. I’m not sure I tested this before. There is a “record.cpp” program in the tests/ directory that you can use to try it. I compiled using MinGW. Let me know if you can try to debug it.

Note a made an addition or two to the code on github so you should probably grab the latest version from there.

—gary

On Apr 18, 2014, at 10:08 AM, MarcusTomlinson notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/MarcusTomlinson/rtaudio master
Or view, comment on, or merge it at:

#8

Commit Summary

• Added an author header to the WASAPI section
• Fixed shutdown crash on certain sample rates
• Support all sample rates for WASAPI
File Changes

• M RtAudio.cpp (38)
Patch Links:

• https://github.com/thestk/rtaudio/pull/8.patch
• https://github.com/thestk/rtaudio/pull/8.diff
—
Reply to this email directly or view it on GitHub.

[MarcusTomlinson]

Hmm, strange. I thought I has tested this too. Yeah sure, I'll have a look soon.

On 23 Apr 2014, at 22:09, garyscavone notifications@github.com wrote:

Hi Marcus,

I tested the WASAPI code and the updated sample rate support seems fine. However, while duplex operation is working, audio input only does not seem to work. I’m not sure I tested this before. There is a “record.cpp” program in the tests/ directory that you can use to try it. I compiled using MinGW. Let me know if you can try to debug it.

Note a made an addition or two to the code on github so you should probably grab the latest version from there.

—gary

On Apr 18, 2014, at 10:08 AM, MarcusTomlinson notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/MarcusTomlinson/rtaudio master
Or view, comment on, or merge it at:

#8

Commit Summary

• Added an author header to the WASAPI section
• Fixed shutdown crash on certain sample rates
• Support all sample rates for WASAPI
File Changes

• M RtAudio.cpp (38)
Patch Links:

• https://github.com/thestk/rtaudio/pull/8.patch
• https://github.com/thestk/rtaudio/pull/8.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

[garyscavone]

Hi Marcus,

I did a little hunting for the problem and I localized it to line 5082:

if ( callbackPushed ) {
  callbackPulled = false;
}

The “callbackPushed” flag can never be true for an input-only stream. Thus, the user callback never gets called after the first call. That said, I still don’t fully understand all parts of the code and thus I’m not sure what the fix is. I tried removing the condition and always setting callbackPulled = false, but the result for audio input was not clean.

Regards,

—gary

On Apr 24, 2014, at 10:10 AM, MarcusTomlinson notifications@github.com wrote:

Hmm, strange. I thought I has tested this too. Yeah sure, I'll have a look soon.

On 23 Apr 2014, at 22:09, garyscavone notifications@github.com wrote:

Hi Marcus,

I tested the WASAPI code and the updated sample rate support seems fine. However, while duplex operation is working, audio input only does not seem to work. I’m not sure I tested this before. There is a “record.cpp” program in the tests/ directory that you can use to try it. I compiled using MinGW. Let me know if you can try to debug it.

Note a made an addition or two to the code on github so you should probably grab the latest version from there.

—gary

On Apr 18, 2014, at 10:08 AM, MarcusTomlinson notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/MarcusTomlinson/rtaudio master
Or view, comment on, or merge it at:

#8

Commit Summary

• Added an author header to the WASAPI section
• Fixed shutdown crash on certain sample rates
• Support all sample rates for WASAPI
File Changes

• M RtAudio.cpp (38)
Patch Links:

• https://github.com/thestk/rtaudio/pull/8.patch
• https://github.com/thestk/rtaudio/pull/8.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.