Added missing SND_SEQ_EVENT_CLOCK event (MIDI Real Time Clock message) f... #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...or timing ignoring.
The event ignoring mechanism is missing SND_SEQ_EVENT_CLOCK from ALSA, which is the event type associated with the MIDI message 0xF8 (Timing Clock). The used SND_SEQ_EVENT_TICK event is not an outside world MIDI message, but a special message generated by the ALSA synth.
I discovered this bug when working with a real Yamaha Clavinova Digital Piano, which was broadcasting 0xF8 messages and RtMidi wasn't properly ignoring them. This proposed patch correctly ignores that message, like the other drivers inside RtMidi.