Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing SND_SEQ_EVENT_CLOCK event (MIDI Real Time Clock message) f... #2

Merged
merged 1 commit into from
Jan 18, 2014

Conversation

hhromic
Copy link

@hhromic hhromic commented Jan 14, 2014

...or timing ignoring.

The event ignoring mechanism is missing SND_SEQ_EVENT_CLOCK from ALSA, which is the event type associated with the MIDI message 0xF8 (Timing Clock). The used SND_SEQ_EVENT_TICK event is not an outside world MIDI message, but a special message generated by the ALSA synth.

I discovered this bug when working with a real Yamaha Clavinova Digital Piano, which was broadcasting 0xF8 messages and RtMidi wasn't properly ignoring them. This proposed patch correctly ignores that message, like the other drivers inside RtMidi.

garyscavone added a commit that referenced this pull request Jan 18, 2014
Added missing SND_SEQ_EVENT_CLOCK event (MIDI Real Time Clock message) f...
@garyscavone garyscavone merged commit 4034140 into thestk:master Jan 18, 2014
@drewish
Copy link
Contributor

drewish commented Jan 19, 2014

Seems like this was applied twice:

parallels@ubuntu:/media/psf/Home/tmp/rtmidi$ make
g++ -O3 -Wall -Iinclude -fPIC -INONE/include  -D__LINUX_ALSA__ -c RtMidi.cpp -o RtMidi.o
RtMidi.cpp: In function ‘void* alsaMidiHandler(void*)’:
RtMidi.cpp:1219:5: error: duplicate case value
RtMidi.cpp:1215:5: error: previously used here
make: *** [RtMidi.o] Error 1

It looks like it's discussed over on this commit: 4034140

@drewish
Copy link
Contributor

drewish commented Jan 19, 2014

#9 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants