Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this work, I try to make buffered Jack output more robust, as I discovered a few annoyances.
It enables some recovery from failures.
When a message is written to the ring buffer by
sendMessage
, the outcome is not checked.If a message too big for the remaining buffer is written, and then passes a short message which succeeds, the validity of the message stream following is potentially broken.
(because the size was communicated onto the size buffer, despite that message data did not go through, or just partial)
The call
jack_midi_event_reserve
can fail with NULL.This case should be checked to prevent crashing. In this case, I will discard the buffered event, also permitting the stream to get back on its feet.