Added Android support to rtmidi #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the correct Android flag
|
OMG, i really really need this. Why this was not mergerd yet? |
|
Looks like other pull requests were merged before mine and there are merge conflicts. The build failures have nothing to do with this pull request though. |
|
@garyscavone Can you try to merge it again? |
|
Can you revise it to put the ANDROID enum at the end of the list? That is what we have been doing with new APIs. |
|
Sure, done. |
|
@garyscavone I updated (and aligned) the enums. |
|
You guys rock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Android support for rtmidi. I tested the implementation using the rtmidi API and confirmed it works.
One caveat is that the single Java class in contrib/java must be included in the final Android application. That class is instantiated and managed by the C++ code but unfortunately it is required by the Android Midi API. Otherwise an Android app should use the regular rtmidi API, no need to deal with Java at all.
The command below is an example on how to build rtmidi with Android support. It targets the SDK API level 32 and generates arm64 binaries.
cmake .. -B arm64 --toolchain <android sdk>/ndk/<ndk version>/build/cmake/android.toolchain.cmake -DANDROID_NDK=<android sdk>/ndk/<ndk version> -DANDROID_ABI=arm64-v8a -DANDROID_PLATFORM=android-32 -DANDROID=32 -DANDROID_STL=c++_shared -DANDROID_USE_LEGACY_TOOLCHAIN_FILE=FALSE