Fix a CFStringRef leak in RTMidi Port Name #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain circumstances when building a compound port name (for instance, with an IAC bus), the string math to concatenate the bus and driver does not release one of the source strings, causing a CFStringRef leak on macOS. This fixes it by doing the appropriate CFRelease after string concatenation.
|
Thanks! Curious if you have a cadence to tag changes. Seems like there’s a few changes since 66.0.0 so wondering if a 6.0.1 might be on the horizon? appreciate the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain circumstances when building a compound port name (for instance, with an IAC bus), the string math to concatenate the bus and driver does not release one of the source strings, causing a CFStringRef leak on macOS.
This fixes it by doing the appropriate CFRelease after string concatenation.