Add application configuration #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradbeam
previously approved these changes
Nov 23, 2020
jgustie
force-pushed
the
app-endpoints
branch
from
1a4d1ef
to
2e10976
Compare
bradbeam
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration for a couple of the UI endpoints, RE. This will help reduce hard coding in the CLI code and keep the definition of the default URLs consolidated in one place.
Note that this technically requires a fix from #9, the environment was excluded from the configuration merge which means it is not being properly read in for defaults (or migrations).