Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optimize flag to the metric specification #5

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Add an optimize flag to the metric specification #5

merged 2 commits into from
Nov 6, 2020

Conversation

jgustie
Copy link
Contributor

@jgustie jgustie commented Oct 30, 2020 •
edited
Loading

This PR adds an optimize field to the metric definition.

@jgustie jgustie marked this pull request as draft October 30, 2020 14:06
@jgustie
Copy link
Contributor Author

jgustie commented Oct 30, 2020

This is still waiting on backend changes to be deployed.

@jgustie jgustie requested a review from bradbeam November 6, 2020 20:15
@jgustie jgustie marked this pull request as ready for review November 6, 2020 20:15
@jgustie jgustie changed the title Add a collectOnly flag to the metric specification Add an optimize flag to the metric specification Nov 6, 2020
@bradbeam
Copy link
Contributor

bradbeam commented Nov 6, 2020

Are we missing v1beta1 and the new crd definitions?

@jgustie
Copy link
Contributor Author

jgustie commented Nov 6, 2020 •
edited
Loading

That's a different PR. Once this gets merged, I'll release redskyops-go and update the controller PR (I leave it as a draft until then).

@bradbeam
Copy link
Contributor

bradbeam commented Nov 6, 2020

Whoops, missed this was not the controller repo.

@jgustie jgustie merged commit 507098b into master Nov 6, 2020
@jgustie jgustie deleted the collect-only branch November 6, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradbeam bradbeam bradbeam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgustie @bradbeam