This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
Fix MTU detection #304
Merged
Fix MTU detection #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
approved these changes
Sep 6, 2020
cuza
added a commit
to cuza/chiaki
that referenced
this pull request
Oct 18, 2020
* upstream/master: Version 1.3.0 PS4 Firmware 8.0 Compatibility (Fix thestr4ng3r#328) Remove sdl2-static from alpine deps Fix MTU detection (Fix thestr4ng3r#303) (thestr4ng3r#304) Add F-Droid info to README.md (thestr4ng3r#308)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the MTU detection's binary search. The values returned by the incoming MTU detection should now not be too large (e.g. an MTU of 1420 made the function return 1421 before).
Additionally, the outgoing MTU detection does not error out if it tries to send a packet that is too large, since this can happen during the binary search. Instead, the function handles a packet that could not be sent the same way as one where the response timed out.
This commit fixes #303 for the tests that I ran.