Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give blasts a "range" using a TimeLimitComponent #155

Closed
cdsupina opened this issue May 19, 2021 · 2 comments · Fixed by #166
Closed

Give blasts a "range" using a TimeLimitComponent #155

cdsupina opened this issue May 19, 2021 · 2 comments · Fixed by #166
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cdsupina
Copy link
Collaborator

Currently blasts will travel until they reach a "despawn line" at a y-value above or below the arena. This is effectively inifinite range. Let's make the game more interesting by adding a finite range to fired blasts by giving them a TimeLimitComponent.

This will also allow us to add items to increase range in the future.
@cdsupina cdsupina added enhancement New feature or request good first issue Good for newcomers labels May 19, 2021
AndreasHempel added a commit to AndreasHempel/theta-wave that referenced this issue Jun 28, 2021
@AndreasHempel
[blasts] Introduce limited range for blasts via DespawnTimeLimitCompo…
8704137 
…nent

Add a DespawnTimeLimitComponent to blasts to have them despawn after a
fixed time based on weapon range and shot velocity

Keep the current behavior of despawning at the border to avoid tracking
blasts that are off the screen

Closes thetawavegame#155
@AndreasHempel AndreasHempel mentioned this issue Jun 28, 2021
Merged
@AndreasHempel
Copy link
Contributor

Spent some time today warming up to Rust, game development, and open source contributions by tackling this. Would appreciate comments on #166 @cdsupina.

@cdsupina
Copy link
Collaborator Author

I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[blasts] Introduce limited range for blasts via DespawnTimeLimitComponent AndreasHempel/theta-wave
2 participants
@AndreasHempel @cdsupina