add EnemyDestroyedEvent and EnemyDestroyedSystem #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigleym
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Thanks! I left a suggestion about using .get over join to get components for a specific entity. I also had one nit about the organization of systems/mod.rs.
Overall, I think having EnemyDestroyedSystem works well for handling enemy deaths and helps isolate a lot of the logic that was present in systems/enemy.rs.
|
@tigleym I exchanged |
tigleym
added a commit
that referenced
this pull request
Nov 17, 2020
add EnemyDestroyedEvent and EnemyDestroyedSystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #67.
I ended up creating a system to handle enemy deaths because spawning entities like the consumable drop and the blast explosion don't necessarily require their own system (I didn't want to create a new explosion system).
I see this event being read in other systems, for example, keeping track of how many enemies the player has destroyed.
I also moved all of the events currently in the game into their own module, rather than keeping them in the already large space_shooter.rs file.