Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5/D3: minor nit #30

Closed
mrose17 opened this issue Oct 11, 2013 · 3 comments
Closed

HTML5/D3: minor nit #30

mrose17 opened this issue Oct 11, 2013 · 3 comments
Assignees

Comments

@mrose17
Copy link
Member

mrose17 commented Oct 11, 2013

i guess i'm a neo-mac guy, because i think that the arrows are reversed on the more-than-five-devices-to-choose-from picker. specifically, when i click on the left arrow, i'd like the choices to scroll to the right; similarly, when i click on the right arrow, i'd like the choices to scroll to the left.

also, could we order the devices in the scroll list? primary sort key=deviceType (e.g., '/device/climate/netatmo/monitor'), and secondary sort key=name (e.g., 'Arden-Arcade')

thanks!

/mtr

@ghost ghost assigned ae9f Oct 11, 2013
@ewilderj
Copy link

+1 on the direction, that's convention these days I think. Click left arrow = you expect to see more of what's on the left = everything scrolls right.

@ae9f
Copy link
Contributor

ae9f commented Oct 11, 2013

Finally some feedback on this (I couldn't make up my mind at the first implementation a couple of months ago, and put it out there for comment). I'm happy to change it based on this 2-0 vote.

Unless there are some unforeseen ripple effects, the sorting should be doable.

@mrose17
Copy link
Member Author

mrose17 commented Oct 11, 2013

groovy! many thanks!

ae9f pushed a commit that referenced this issue Oct 13, 2013
1. One-time auto scroll >3 actor rows (#27)
2. Actors scroll remembered (#28)
3. Reverse multi-drilldown arrow behavior (#30)
4. Sort multi-drilldown icons (#30)
@ae9f ae9f closed this as completed Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants