Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Annotations #1

Open
Hazerre opened this issue Mar 14, 2024 · 4 comments
Open

Service Annotations #1

Hazerre opened this issue Mar 14, 2024 · 4 comments

Comments

@Hazerre
Copy link

Hazerre commented Mar 14, 2024

Hey there. Your SteamCMD chart is great. My only request would be allow us to set annotations on the service through the use of the values yaml. This is very useful for things like MetalLB's IP address sharing. Thanks.

https://metallb.universe.tf/usage/#ip-address-sharing

@thetredev
Copy link
Owner

thetredev commented Mar 14, 2024

Thank you! I can try this weekend probably, I need to setup a new testing cluster anyway.

Just to make sure, you mean metadata/annotations, right? Like this:

metadata:
  annotations:
    some-label-key: "some-label-value"

where you would define the whole annotations block yourself using values.yaml? For example

deployment:
  containerName: counter-strike2
  pullPolicy: IfNotPresent
  game: cs2

network:
  # -----> ANNOTATIONS HERE <-----
  service:
    annotations:
      some-key: "some-value"
  ip: "192.168.178.20"
  ports:
    server: 27015
    rcon:
      enabled: true
    ssh:
      enabled: true
      port: 22
      secretName: ssh-access

storage: "5Gi"

environment:
  timezone: "Etc/UTC"
  map: de_dust2
  maxplayers: 32

@Hazerre
Copy link
Author

Hazerre commented Mar 14, 2024

Yeah similar to that.

Something like this could be on the service.yaml side:

  annotations:
{{ toYaml .Values.serviceAnnotations | indent 4 }}
spec:

Then just throw this into the values

serviceAnnotations:
  my-generic-label-here: "contents-of-label"

@thetredev
Copy link
Owner

Great, that would clean up values.yaml a bit. Thanks for the suggestion.

thetredev added a commit that referenced this issue Mar 16, 2024
Signed-off-by: Timo Reichl <thetredev@gmail.com>
@thetredev
Copy link
Owner

@Hazerre should be fixed now. Can you test as well since I don't know your specific use case?

@thetredev thetredev reopened this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants