Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are sensible to current load #346

Open
kapouer opened this issue Jan 24, 2019 · 1 comment
Open

tests are sensible to current load #346

kapouer opened this issue Jan 24, 2019 · 1 comment

Comments

@kapouer
Copy link

kapouer commented Jan 24, 2019

The timeouts in unit tests are probably too short to resist some load on a CI server.

@kapouer
Copy link
Author

kapouer commented Jan 24, 2019

I start with this:

--- a/test/unit/dropBeforeAccept.js
+++ b/test/unit/dropBeforeAccept.js
@@ -41,7 +41,7 @@
           stopServer();
         });

-      }, 500);
+      }, 5000);
     });

     var client = new WebSocketClient();
@@ -57,7 +57,7 @@
     setTimeout(function() {
       // Bail on the connection before we hear back from the server.
       client.abort();
-    }, 250);
+    }, 2500);

   });
 });
--- a/test/unit/request.js
+++ b/test/unit/request.js
@@ -77,7 +77,7 @@

     var timer = setTimeout(function() {
       t.fail('Timeout waiting for client event');
-    }, 2000);
+    }, 20000);

     client.connect('ws://localhost:64321/', 'some_protocol_here');
     client.on('connect', function(connection) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant