Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use int64 instead of int for metadata version #240

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

arbll
Copy link
Contributor

@arbll arbll commented Mar 26, 2022

Release Notes: Metadata version now uses int64

Types of changes:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:

We have a high write throughput on our TUF repositories and there's a good chance we'll reach 2B+ snapshots versions in the future which would break our clients on 32bit archs. Let's standardize to int64 to avoid any surprises.

@coveralls
Copy link

coveralls commented Mar 26, 2022

Pull Request Test Coverage Report for Build 2045946320

  • 14 of 21 (66.67%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 71.277%

Changes Missing Coverage Covered Lines Changed/Added Lines %
verify/verify.go 3 4 75.0%
repo.go 6 9 66.67%
util/util.go 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
util/util.go 1 40.84%
Totals Coverage Status
Change from base Build 2029695489: 0.0%
Covered Lines: 2278
Relevant Lines: 3196

💛 - Coveralls

@arbll arbll changed the title user int64 for version use int64 instead of int for metadata version Mar 26, 2022
@arbll
Copy link
Contributor Author

arbll commented Apr 9, 2022

@asraa @ethan-lowman-dd Gentle bump, let me know if there's anything blocking this. Our backend can wait but we'd like to include it asap in our clients

Copy link
Contributor

@ethan-lowman-dd ethan-lowman-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe the goreleaser configuration now requires conventional commit messages with annotations for breaking changes. Could you rebase and edit the commit message with format described here? https://www.conventionalcommits.org/en/v1.0.0/

@asraa asraa merged commit 507e038 into theupdateframework:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants