Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove GITHUB_TOKEN from arnested/go-version-action #259

Merged

Conversation

arnested
Copy link
Contributor

@arnested arnested commented Apr 5, 2022

Hi,

I'm the author of arnested/go-version-action.

The action doesn't need a GITHUB_TOKEN anymore.

Instead of getting the Go releases from git tags using GitHub's API (and thus needing the token to avoid being rate limited) it pulls the versions from https://go.dev/dl/?mode=json&include=all.

@rdimitrov rdimitrov self-requested a review April 5, 2022 11:31
rdimitrov
rdimitrov previously approved these changes Apr 5, 2022
Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnested - Thank you for reaching out and for addressing that change in go-tuf too! 👍

edit: Forgot to say that I'd suggest to reword the commit message to comply with the conventional commit guideline, otherwise the linter GitHub action will probably fail 👍

The action `arnested/go-version-action` doesn't need GITHUB_TOKEN
anymore.

Instead of getting the Go releases from git tags using GitHub's
API (and thus needing the token to avoid being rate limited) it pulls
the versions from https://go.dev/dl/?mode=json&include=all.
@arnested arnested force-pushed the avoid-need-for-github-token branch from 7f6d31a to 5c72b12 Compare April 5, 2022 11:48
@arnested arnested changed the title arnested/go-version-action doesn't need GITHUB_TOKEN anymore chore: remove GITHUB_TOKEN from arnested/go-version-action Apr 5, 2022
@arnested
Copy link
Contributor Author

arnested commented Apr 5, 2022

@arnested - Thank you for reaching out and for addressing that change in go-tuf too! +1

There were only five projects using GITHUB_TOKEN (not counting my own) so I thought it was a good opportunity to be helpful. Don't expect the same level of service if this ever gains widespread popularity 😛

edit: Forgot to say that I'd suggest to reword the commit message to comply with the conventional commit guideline, otherwise the linter GitHub action will probably fail +1

Fixed 👍

@rdimitrov rdimitrov self-requested a review April 5, 2022 12:48
rdimitrov
rdimitrov previously approved these changes Apr 5, 2022
asraa
asraa previously approved these changes Apr 5, 2022
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This supersedes #260 too

@asraa
Copy link
Contributor

asraa commented Apr 13, 2022

@hosseinsia could you PTAL? should be easy

znewman01
znewman01 previously approved these changes Apr 28, 2022
@znewman01 znewman01 dismissed stale reviews from asraa, rdimitrov, and themself via 6046ed9 April 28, 2022 17:42
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for submitting this @arnested !

@mnm678 mnm678 merged commit 57b9f1e into theupdateframework:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants