-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creating and modifying repos #3
Conversation
Ping @heavenlyhash more eyeballs on this would be great. |
return nil | ||
} | ||
|
||
func hash256(r io.Reader) ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's default to using SHA-512. It's quite a bit faster on x86_64.
2555384
to
67c839b
Compare
Signed-off-by: Lewis Marshall <lewis@lmars.net>
67c839b
to
4134235
Compare
@titanous @heavenlyhash comments addressed and implementation changed to match proposal #4. I plan to do the following in smaller PRs once this is merged:
|
This is a Go implementation of [The Update Framework (TUF)](http://theupdateframework.com/), | ||
a framework for securing software update systems. | ||
|
||
Reference documentation can be found in [this Github repository](https://github.com/theupdateframework/tuf). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this sentence is necessary, anyone interested can follow the link above.
4134235
to
51ac540
Compare
@titanous @heavenlyhash comments addressed |
type ErrInsufficientSignatures struct { | ||
name string | ||
err error | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields should be exported (in all of them).
Signed-off-by: Lewis Marshall <lewis@lmars.net>
51ac540
to
a43b1cb
Compare
@titanous comments addressed |
Looks like the hex encoding isn't working as expected? Probably needs a pointer receiver for the
|
Also, all JSON files should be formatted with |
This works, which is unexpected:
|
All expires should be coerced to UTC before saving. |
One of the initial commands should create the |
|
Signed-off-by: Lewis Marshall <lewis@lmars.net>
Signed-off-by: Lewis Marshall <lewis@lmars.net>
89fa207
to
45855b6
Compare
} | ||
|
||
type ErrFileNotFound struct { | ||
path string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be exported.
Signed-off-by: Lewis Marshall <lewis@lmars.net>
Signed-off-by: Lewis Marshall <lewis@lmars.net>
Signed-off-by: Lewis Marshall <lewis@lmars.net>
45855b6
to
5b9a59e
Compare
LGTM |
Support creating and modifying repos
Use endophage for client imports
…wman/delegations-in-client Iteration on "Support delegations in client"
…helpers Add version helpers
# This is the 1st commit message: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175 # This is the commit message theupdateframework#2: stash # This is the commit message theupdateframework#3: Add tests to make sure the top level targets 'delegation' edge has associated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role # This is the commit message theupdateframework#4: [Delegations prereq] Make signers addressible by key ID in LocalStore Splitting up theupdateframework#175 # This is the commit message theupdateframework#5: Clarify naming # This is the commit message theupdateframework#6: Add local_store_test.go # This is the commit message theupdateframework#7: Another test case # This is the commit message theupdateframework#8: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175
# This is the 1st commit message: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175 # This is the commit message theupdateframework#2: stash # This is the commit message theupdateframework#3: Add tests to make sure the top level targets 'delegation' edge has associated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role # This is the commit message theupdateframework#4: [Delegations prereq] Make signers addressible by key ID in LocalStore Splitting up theupdateframework#175 # This is the commit message theupdateframework#5: Clarify naming # This is the commit message theupdateframework#6: Add local_store_test.go # This is the commit message theupdateframework#7: Another test case # This is the commit message theupdateframework#8: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175 # This is the commit message theupdateframework#9: stash # This is the commit message theupdateframework#10: Add tests to make sure the top level targets 'delegation' edge has associated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role
…framework#3) * docs: add comments describing the different types Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: add golangci and codeql Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: begin adding tests Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: add licence notice Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: update licence year to 2023 Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: fix linting error Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: temp limit ci to ubuntu so we don't waste GHA resources Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
* docs: add comments describing the different types Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: add golangci and codeql Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: begin adding tests Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: add licence notice Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: update licence year to 2023 Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: fix linting error Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> * chore: temp limit ci to ubuntu so we don't waste GHA resources Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com> Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
There are a few TODOs in here which I plan to address, but opening to get feedback on the approach so far.
ping @titanous