Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix delegation null json value interoperability #410

Merged

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Oct 5, 2022

Signed-off-by: Asra Ali asraa@google.com

When reseting a targets delegations, the roles are set to a null JSON value. Instead, remove the entire delegations field.

Added a test in the python client interoperability test

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #
Release Notes:

* fix(repo): Fixes a `null` JSON value that appears from using `repo.ResetTargetsDelegations`. This broke compatibility with python-tuf client

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: Asra Ali <asraa@google.com>
@trishankatdatadog trishankatdatadog merged commit 4705874 into theupdateframework:master Oct 6, 2022
znewman01 pushed a commit to znewman01/go-tuf that referenced this pull request May 22, 2023
…ork#410)

fix: fix delegation null json value

Signed-off-by: Asra Ali <asraa@google.com>

Signed-off-by: Asra Ali <asraa@google.com>
Co-authored-by: Radoslav Dimitrov <dimitrovr@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ResetTargetsDelegations changes delegations.roles to null value: deserialization error
4 participants