fix: fix verification to continue on invalid sigs #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
joshuagl
previously approved these changes
Oct 17, 2022
Signed-off-by: Asra Ali <asraa@google.com>
rdimitrov
previously approved these changes
Oct 19, 2022
Signed-off-by: Asra Ali <asraa@google.com>
trishankatdatadog
approved these changes
Oct 28, 2022
rdimitrov
approved these changes
Oct 28, 2022
BaptisteFoy
pushed a commit
to BaptisteFoy/go-tuf
that referenced
this pull request
Dec 22, 2022
…#418) * fix: fix verification to continue on invalid sigs Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Baptiste Foy <baptiste.foy@datadoghq.com>
BaptisteFoy
pushed a commit
to BaptisteFoy/go-tuf
that referenced
this pull request
Jan 6, 2023
…#418) * fix: fix verification to continue on invalid sigs Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Baptiste Foy <baptiste.foy@datadoghq.com>
znewman01
pushed a commit
to znewman01/go-tuf
that referenced
this pull request
May 22, 2023
…#418) * fix: fix verification to continue on invalid sigs Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Fixes #370
Blocked on #417
As described in the issue, client will currently fail on any single invalid signature rather than counting the number of valid signatures. The fix is that it continues on invalid signatures, not counting them to the threshold of valid signatures.
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #
Release Notes:
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following requirements: