feat: increase scrypt parameters #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibault Normand <me@zenithar.org>
Signed-off-by: Thibault Normand <me@zenithar.org>
Signed-off-by: Thibault Normand <me@zenithar.org>
rdimitrov
force-pushed
the
zenithar/security_increase_scrypt_parameters
branch
from
badc5d9
to
bfacef0
Compare
rdimitrov
approved these changes
Jul 3, 2023
|
@trishankatdatadog @znewman01 @mnm678 - hey, can you have a look so we can move this forward? |
znewman01
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
Release Notes:
Increase the default
scryptKDF parameters to a more recent parameter set.Types of changes:
Description of the changes being introduced by the pull request:
Provides backward compatibility to for legacy parameter set, and provides more recent parameter based on various recommendations (Scrypt Author / OWASP).
Legacysettings (2^15, 8, 1)Standardrecommended settings (2^16, 8, 1) => Targeting ~100msOWASPrecommended settings (2^17, 8, 1)Please verify and check that the pull request fulfills the following requirements: