fix: Set sig to Array when empty #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnm678
reviewed
Jul 31, 2023
rdimitrov
force-pushed
the
531-set-sig-to-array-when-empty
branch
from
efe4b1c
to
554154d
Compare
|
@rdimitrov is there anything more I can do to help get this merged? |
Signed-off-by: Edward Brough <edward.brough@gmail.com>
Signed-off-by: Edward Brough <edward.brough@gmail.com>
trishankatdatadog
force-pushed
the
531-set-sig-to-array-when-empty
branch
from
554154d
to
d7d591f
Compare
rdimitrov
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #531
Release Notes: missing signatures are now empty arrays rather than null
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
The init command and others now returns an empty array rather than a null for the signatures field.
Please verify and check that the pull request fulfills the following requirements: