fix: add-signature to read from stdin #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChevronTango
force-pushed
the
529-add-signature-to-read-from-stdin
branch
from
880032e
to
66510c8
Compare
mnm678
reviewed
Jul 31, 2023
mnm678
previously approved these changes
Jul 31, 2023
rdimitrov
reviewed
Aug 7, 2023
|
@rdimitrov is there anything more I can do to help get this merged? |
Could we resolve conflicts first pls? |
Thanks @trishankatdatadog that should be merged in now. |
rdimitrov
previously approved these changes
Oct 10, 2023
Not sure why yet, but GH claims cannot rebase master into this branch due to conflicts. Would you pls check again? |
ChevronTango
force-pushed
the
529-add-signature-to-read-from-stdin
branch
2 times, most recently
from
818e640
to
3efe5b8
Compare
no idea why that was still being picky... but should be fine now. |
rdimitrov
approved these changes
Oct 11, 2023
trishankatdatadog
approved these changes
Oct 11, 2023
Signed-off-by: Edward Brough <edward.brough@gmail.com>
Co-authored-by: Marina Moore <mnm678@users.noreply.github.com> Signed-off-by: ChevronTango <edward.brough@gmail.com>
rdimitrov
force-pushed
the
529-add-signature-to-read-from-stdin
branch
from
3efe5b8
to
cd741b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #529
Release Notes: add-signature to read from stdin
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
add-signature to read from stdin
Please verify and check that the pull request fulfills the following requirements: