simpler NormalizeTargets #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please add a DCO sign-off (I just realized that we're missing a CONTRIBUTING file). |
|
Ah yep, no worries. Are you interested in the changes I made around verifiers (see my master branch, signed/verifiers.go and updates to signed/verify.go)? I'd be happy to port them over. |
|
Yeah, pluggable signature verification makes sense, ideally with RSA off by default. |
|
Cool, I'll get that ported sometime this week |
|
ugh, ignore for a bit, I screwed up my branches... :-P |
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
|
There we go. |
|
LGTM, Thanks! |
rdimitrov
pushed a commit
to rdimitrov/go-tuf
that referenced
this pull request
Jan 25, 2024
theupdateframework#82) Since TUF spec 1.0.32 the key type for ecdsa does not include the parameters, they are only part of the key-scheme. This commit updates the default keytype to not include the parameters, but includes a compatibility key type to be able to accept metadata compliant with older versions of the spec. Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
rdimitrov
pushed a commit
that referenced
this pull request
Jan 29, 2024
#82) Since TUF spec 1.0.32 the key type for ecdsa does not include the parameters, they are only part of the key-scheme. This commit updates the default keytype to not include the parameters, but includes a compatibility key type to be able to accept metadata compliant with older versions of the spec. Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.Join("/", foo)will always add a/on the front offooand additionally apath.Cleanhappens internally as part ofpath.Join