type the No valid trust data error #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
reviewed
Aug 14, 2017
client/client.go
Outdated
| @@ -595,6 +595,12 @@ type TargetSignedStruct struct { | |||
| Signatures []data.Signature | |||
| } | |||
|
|
|||
| type NoValidTrustDataError string | |||
There was a problem hiding this comment.
Do we want to name this something more like NoSuchTarget? Because there is already a ErrRepositoryNotExist which returns text similar to "... does not have trust data for ...", and the error type name would be clearer I think. Similarly, would be nice if we could say something like "No valid trust data for target %s" instead.
|
Can we also return the same error in |
cyli
reviewed
Aug 14, 2017
client/client.go
Outdated
| @@ -595,6 +595,12 @@ type TargetSignedStruct struct { | |||
| Signatures []data.Signature | |||
| } | |||
|
|
|||
| type ErrNoSuchTarget string | |||
There was a problem hiding this comment.
There seems to be a lint error because this error doesn't have a comment. (You can verify with make lint).
cyli
approved these changes
Aug 14, 2017
Signed-off-by: Kyle Spiers <kyle@spiers.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kyle Spiers kyle@spiers.me