Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add classes for complex metadata fields #1139

Closed
lukpueh opened this issue Sep 10, 2020 · 0 comments · Fixed by #1360
Closed

Add classes for complex metadata fields #1139

lukpueh opened this issue Sep 10, 2020 · 0 comments · Fixed by #1360
Assignees
@MVrachev
Labels
enhancement
Projects
TUF refactor towards 1.0.0
Milestone
Foundations

Comments

@lukpueh
Copy link
Member

lukpueh commented Sep 10, 2020

Coordinate with #1133 and #1137

Description of issue or feature request:
For consistent use of OOP we should provide classes for all complex metadata fields
and not only for the outer metadata signature wrapper and the inner signed metadata.

This would make the used metadata format more explicit and might have a positive effect on metadata schema validation (see discussion in #1130).

Current behavior:
Mixed use of classes and dictionaries for TUF metadata

Expected behavior:
Provide classes for all complex metadata fields, i.e. 'signatures' (in
Metadata) 'meta'/'targets' (in Timestamp, Snapshot, Targets), 'delegations'
(in Targets), 'keys'/'roles' (in not yet existent Delegation), ...
@lukpueh lukpueh added this to To do in TUF refactor towards 1.0.0 via automation Sep 10, 2020
@lukpueh lukpueh added the good first issue Bite-sized items for first time contributors label Sep 10, 2020
@lukpueh lukpueh added this to the Foundations milestone Sep 10, 2020
@lukpueh lukpueh mentioned this issue Sep 10, 2020
Closed
lukpueh added a commit to lukpueh/tuf that referenced this issue Sep 10, 2020
@lukpueh
Ticketize doc header todo items
228a4c7 
See:
Add root metadata class to new TUF metadata model theupdateframework#1137
Add classes for complex metadata fields theupdateframework#1139
Add input validation to simple metadata api theupdateframework#1140

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
MVrachev pushed a commit to MVrachev/tuf that referenced this issue Sep 17, 2020
@lukpueh @MVrachev
Ticketize doc header todo items
db6d0f8 
See:
Add root metadata class to new TUF metadata model theupdateframework#1137
Add classes for complex metadata fields theupdateframework#1139
Add input validation to simple metadata api theupdateframework#1140

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@sechkova sechkova mentioned this issue Oct 28, 2020
Closed
@joshuagl joshuagl mentioned this issue Oct 30, 2020
Merged
3 tasks
@sechkova sechkova mentioned this issue Nov 20, 2020
Closed
@MVrachev MVrachev mentioned this issue Nov 25, 2020
Closed
3 tasks
@lukpueh lukpueh mentioned this issue Jan 29, 2021
Merged
3 tasks
@lukpueh lukpueh mentioned this issue Mar 9, 2021
Merged
17 tasks
@sechkova sechkova mentioned this issue Mar 12, 2021
Closed
@MVrachev MVrachev mentioned this issue Mar 31, 2021
Merged
3 tasks
@MVrachev MVrachev self-assigned this Apr 7, 2021
This was referenced Apr 20, 2021
Closed
Merged
@jku jku closed this as completed in #1360 Apr 29, 2021
TUF refactor towards 1.0.0 automation moved this from To do to Done Apr 29, 2021
@MVrachev MVrachev mentioned this issue Apr 29, 2021
Merged
3 tasks
@MVrachev MVrachev removed the good first issue Bite-sized items for first time contributors label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MVrachev MVrachev

Labels
enhancement
Projects
No open projects
TUF refactor towards 1.0.0
  
Done
Milestone
Foundations
Development

Successfully merging a pull request may close this issue.

New API: Add Key and Role classes MVrachev/tuf
3 participants
@lukpueh @joshuagl @MVrachev