Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock the repository if update / download running #369

Closed
julianhille opened this issue Aug 29, 2016 · 6 comments
Closed

lock the repository if update / download running #369

julianhille opened this issue Aug 29, 2016 · 6 comments
Assignees

Comments

@julianhille
Copy link
Contributor

The repository should be locked while updating so that not two concurrent processes do not change it at the same time.

@JustinCappos
Copy link
Member

This is something we are leaving up to the repository developers. Yes,
this needs to happen, just like one needs to serve content in some way
(e.g., using HTTP or FTP). We don't prescribe a specific way to do this
and leave it up to the repository implementers.

On Mon, Aug 29, 2016 at 12:09 PM, Julian Hille notifications@github.com
wrote:

The repository should be locked while updating so that not two concurrent
processes do not change it at the same time.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#369, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0XD_hcEWzlqmBYvDXGOJpXumeG4JtHks5qkwQvgaJpZM4Jvoam
.

@julianhille
Copy link
Contributor Author

I thought it would just be very easy to add a flock to "the_repository_dir/.lock" with an configurable time_delta when to reclaim the lock if a process before may have been killed or cancelled and the flock file still exists.

@julianhille
Copy link
Contributor Author

At least we should add a note to the readme that concurrent processes may harm the repo and that the lock is up to the repository maintainer?

Just for completeness im talking about the update client :>

@JustinCappos
Copy link
Member

Ah, sure. We should update the docs in both the client and repository to make this clear.

@vladimir-v-diaz: can you take a look at this and ensure this is clear?

@trishankatdatadog
Copy link
Member

This is connected to #49

@mnm678 mnm678 self-assigned this Dec 17, 2019
@mnm678
Copy link
Contributor

mnm678 commented Jan 7, 2020

#972 added an explanation of this limitation to the readme.

@mnm678 mnm678 closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants