Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata move from current to previous... #40

Closed
akonst opened this issue Mar 15, 2013 · 2 comments
Closed

Metadata move from current to previous... #40

akonst opened this issue Mar 15, 2013 · 2 comments
Labels

Comments

@akonst
Copy link
Contributor

akonst commented Mar 15, 2013

Situation: After making a delegation, on the download by the client, client's metadata was updated and the file download itself was successful. However, on the second try, when current metadata files are moved to the previous directory, following happens:

Traceback (most recent call last):
File "test_extraneous_dependencies_attack.py", line 213, in
test()
File "test_extraneous_dependencies_attack.py", line 192, in test
urllib_tuf.urlretrieve(url_to_file, downloaded_file)
File "/home/zk/Git/tuf/tuf/interposition/init.py", line 124, in __urllib_urlretrieve
return updater.retrieve(url, filename=filename, reporthook=reporthook, data=data)
File "/home/zk/Git/tuf/tuf/interposition/updater.py", line 141, in retrieve
temporary_directory, temporary_filename = self.download_target(target_filepath)
File "/home/zk/Git/tuf/tuf/interposition/updater.py", line 60, in download_target
targets = [self.updater.target(target_filepath)]
File "/home/zk/Git/tuf/tuf/client/updater.py", line 1432, in target
self._refresh_targets_metadata(include_delegations=True)
File "/home/zk/Git/tuf/tuf/client/updater.py", line 1268, in _refresh_targets_metadata
self._update_metadata_if_changed(rolename)
File "/home/zk/Git/tuf/tuf/client/updater.py", line 814, in _update_metadata_if_changed
self._update_metadata(metadata_role, compression=compression)
File "/home/zk/Git/tuf/tuf/client/updater.py", line 700, in _update_metadata
shutil.move(current_filepath, previous_filepath)
File "/usr/lib/python2.7/shutil.py", line 299, in move
copy2(src, real_dst)
File "/usr/lib/python2.7/shutil.py", line 128, in copy2
copyfile(src, dst)
File "/usr/lib/python2.7/shutil.py", line 83, in copyfile
with open(dst, 'wb') as fdst:
IOError: [Errno 2] No such file or directory: u'/home/zk/Git/tuf/tuf/tests/system_tests/tmp56Of78/tuf_client/metadata/previous/targets/role1.txt'

@ghost ghost assigned vladimir-v-diaz Mar 15, 2013
@vladimir-v-diaz
Copy link
Contributor

https://github.com/akonst/tuf/blob/master/tuf/client/updater.py#L698

Immediately before line 698, add this:
tuf.util.ensure_parent_dir(previous_filepath)

That might solve the problem.

@vladimir-v-diaz
Copy link
Contributor

This was fixed and confirmed months ago.

joshuagl referenced this issue in joshuagl/tuf Feb 27, 2020
In PR #40 aginst the specification "root.json" has been removed from
the meta dictionary in "snapshot.json".

Update generate_snapshot_metadata() to no longer add an entry for
root.json to root.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Feb 27, 2020
The specification was updated in PR #40 to remove root.json from
snapshot.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Feb 27, 2020
In PR #40 aginst the specification "root.json" has been removed from
the meta dictionary in "snapshot.json".

Update generate_snapshot_metadata() to no longer add an entry for
root.json to root.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Feb 27, 2020
In PR #40 aginst the specification "root.json" has been removed from
the meta dictionary in "snapshot.json".

Update generate_snapshot_metadata() to no longer add an entry for
root.json to root.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Feb 27, 2020
The specification was updated in PR #40 to remove root.json from
snapshot.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Feb 28, 2020
The specification was updated in PR #40 to remove root.json from
snapshot.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Mar 4, 2020
In PR #40 aginst the specification "root.json" has been removed from
the meta dictionary in "snapshot.json".

Update generate_snapshot_metadata() to no longer add an entry for
root.json to root.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Mar 4, 2020
The specification was updated in PR #40 to remove root.json from
snapshot.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Mar 11, 2020
In PR #40 aginst the specification "root.json" has been removed from
the meta dictionary in "snapshot.json".

Update generate_snapshot_metadata() to no longer add an entry for
root.json to root.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/tuf Mar 11, 2020
The specification was updated in PR #40 to remove root.json from
snapshot.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
mnm678 pushed a commit to mnm678/tuf that referenced this issue Apr 1, 2020
In PR theupdateframework#40 aginst the specification "root.json" has been removed from
the meta dictionary in "snapshot.json".

Update generate_snapshot_metadata() to no longer add an entry for
root.json to root.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
mnm678 pushed a commit to mnm678/tuf that referenced this issue Apr 1, 2020
The specification was updated in PR theupdateframework#40 to remove root.json from
snapshot.json

Signed-off-by: Joshua Lock <jlock@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants