Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Refactor client bootstrap #1715

Merged

Conversation

jku
Copy link
Member

@jku jku commented Dec 8, 2021

Setting up the client (when using RepositorySimulator) can be a bit
cleaner.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com


just tiny test refactor

Setting up the client (when using RepositorySimulator) can be a bit
cleaner.

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@jku jku force-pushed the tests-sim-updater-bootstrap branch from 957e4a1 to b34d1b4 Compare December 9, 2021 07:46
@jku
Copy link
Member Author

jku commented Dec 9, 2021

Fixed the issues Kairo pointed out in test_updater_consistent_snapshot.py. Other files were not touched

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1557693271

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.581%

Totals Coverage Status
Change from base Build 1554266096: 0.0%
Covered Lines: 4032
Relevant Lines: 4116

💛 - Coveralls

Copy link
Collaborator

@kairoaraujo kairoaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sechkova sechkova merged commit bdf1cbb into theupdateframework:develop Dec 10, 2021
@lukpueh lukpueh mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants