Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable python 3.12 #2518

Merged
merged 1 commit into from
Dec 4, 2023
Merged

build: Enable python 3.12 #2518

merged 1 commit into from
Dec 4, 2023

Conversation

NicholasTanz
Copy link
Contributor

@NicholasTanz NicholasTanz commented Dec 3, 2023

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #2499

*build: Enable python 3.12 **:

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: E3E <ntanzill@purdue.edu>
@NicholasTanz
Copy link
Contributor Author

hey @jku , I was wondering if you could take a look at this pr when you got a chance. thanks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7074663663

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.803%

Totals Coverage Status
Change from base Build 6943374266: 0.0%
Covered Lines: 1358
Relevant Lines: 1381

💛 - Coveralls

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good: apparently no code changes are required.

I've changed the CI settings to require the 3.12 checks: that also seems to work based on re-running the tests here.

Cheers!

@jku jku merged commit e989c14 into theupdateframework:develop Dec 4, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: Enable python 3.12
3 participants