Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Start using ruff ruleset "flake8-bandit" #2571

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

jku
Copy link
Member

@jku jku commented Feb 23, 2024

  • Remove bandit
  • Add ruff ruleset "flake8-bandit"
  • verify_release is now checked by bandit
    • Avoid some asserts as suggested
    • ignore a subprocess.run lint: it seems dumb
  • ignore all bandit rules for tests and examples (just like before)

The ruff rules list is not 100% same as bandit itself but very close.

* Remove bandit
* Add ruff ruleset "flake8-bandit"
* verify_release is now checked by bandit
  * Avoid some asserts as suggested
  * ignore a subprocess.run lint: it seems dumb
* ignore all bandit rules for tests and examples (just like before)

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku mentioned this pull request Feb 23, 2024
21 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8022223491

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.725%

Totals Coverage Status
Change from base Build 8005157007: 0.0%
Covered Lines: 1463
Relevant Lines: 1488

💛 - Coveralls

@lukpueh lukpueh merged commit 331863e into theupdateframework:develop Feb 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants