Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Simplify testing #2610

Merged
merged 1 commit into from Apr 22, 2024
Merged

Conversation

jku
Copy link
Member

@jku jku commented Apr 16, 2024

  • Don't try to handle sslib main test within the matrix
  • Put it in a separate workflow
  • Include the new workflow in CI but not in CD
  • Bonus: Make cache-dependency-path more complete

Fixes #2604


@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8701688096

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.592%

Totals Coverage Status
Change from base Build 8700988091: 0.0%
Covered Lines: 1466
Relevant Lines: 1491

💛 - Coveralls

* Don't try to handle sslib main test within the matrix
* Put it in a separate workflow
* Include the new workflow in CI but not in CD
* Bonus: Make cache-dependency-path more complete

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Copy link
Member Author

jku commented Apr 16, 2024

@lukpueh what do you think?

  • should fix the dependency issue
  • workflow now does not need a Github PHD to modify
  • PRs still get a "some checks were not successful" which is a little annoying for external contributors but I think it's ok: we do want know if things break with sslib main...

@jku jku marked this pull request as ready for review April 16, 2024 07:35
@jku
Copy link
Member Author

jku commented Apr 16, 2024

Hmm, the check names now changed somehow -- it's different from what the expected check names are?

Maybe:

  • "CI" workflow only had one job previously: GitHub decides to not include "CI" in the name
  • but now there are two jobs in "CI" so Github includes the name?

Github tries to be helpful and manages to be annoying.

@lukpueh
Copy link
Member

lukpueh commented Apr 16, 2024

Hmm, the names now changed somehow -- it's different from what the expected test names are?

Yes, we just have to uncheck old expected checks and check new ones.

Maybe:

  • "CI" workflow only had one job previously: GitHub decides to not include "CI" in the name
  • but now there are two jobs in "CI" so Github includes the name?

Could be. It also doesn't include the toxenv py in the name anymore.

@jku
Copy link
Member Author

jku commented Apr 16, 2024

It also doesn't include the toxenv py in the name anymore.

Oh I missed that!

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Do I understand correctly that we don't need to set continue-on-error, because default is false and so a failure in tests, which is included in cd.yml and needed by build, blocks build, but a failure in sslib-main, which is is not included or needed, does not?

@lukpueh
Copy link
Member

lukpueh commented Apr 16, 2024

Hmm, the names now changed somehow -- it's different from what the expected test names are?

Yes, we just have to uncheck old expected checks and check new ones.

IIUC, right now, I can only un-require the old checks, but the settings UI won't show me the new ones until the PR is merged. I suggest we merge as is, bypassing the branch protection, and then I migrate the settings.

@jku
Copy link
Member Author

jku commented Apr 16, 2024

Do I understand correctly that we don't need to set continue-on-error, because default is false and so a failure in tests, which is included in cd.yml and needed by build, blocks build, but a failure in sslib-main, which is is not included or needed, does not?

Yes that's my understanding.

For CI workflows:

  • CI workflow will fail if _test_sslib_main.yml fails
  • but that's ok since the "required statuses" feature uses specific status checks and not the workflow state

@jku jku merged commit 9db9277 into theupdateframework:develop Apr 22, 2024
22 of 23 checks passed
@jku
Copy link
Member Author

jku commented Apr 22, 2024

merged, I'll modify the required checks now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should build job require prior test job to pass?
3 participants