New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: Simplify testing #2610
Conversation
Pull Request Test Coverage Report for Build 8701688096Details
💛 - Coveralls |
* Don't try to handle sslib main test within the matrix * Put it in a separate workflow * Include the new workflow in CI but not in CD * Bonus: Make cache-dependency-path more complete Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@lukpueh what do you think?
|
Hmm, the check names now changed somehow -- it's different from what the expected check names are? Maybe:
Github tries to be helpful and manages to be annoying. |
Yes, we just have to uncheck old expected checks and check new ones.
Could be. It also doesn't include the toxenv |
Oh I missed that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Do I understand correctly that we don't need to set continue-on-error
, because default is false
and so a failure in tests
, which is included in cd.yml
and needed by build
, blocks build
, but a failure in sslib-main
, which is is not included or needed, does not?
IIUC, right now, I can only un-require the old checks, but the settings UI won't show me the new ones until the PR is merged. I suggest we merge as is, bypassing the branch protection, and then I migrate the settings. |
Yes that's my understanding. For CI workflows:
|
merged, I'll modify the required checks now... |
Fixes #2604