made variable public #2647
Merged
made variable public #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: h4l0gen <ks3913688@gmail.com>
|
I have two choices for this:
I used first option here, as i can see in codebase there is no special constraint on using DEFAULT_PAYLOAD_TYPE variable, so there is no meaning of using @Property. it will just make things complex. Please tell me your thoughts?
|
Signed-off-by: Kapil Sharma <ks3913688@gmail.com>
Pull Request Test Coverage Report for Build 9269100973Details
💛 - Coveralls |
|
Hi @jku, If it looks good to you, can we approve and merge this? Thank you👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
It makes _DEAFULT_PAYLOAD_TYPE variable public, so that flake8 linter don't show any error.
Fixes #2598