Deduplicate signatures with the same key_id. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only verify one signature for one key_id, otherwise an attacker owning one key could simply duplicate one valid signature and thus increasing the number of signatures that are valid. This bypass the limitation of threshold. Tested: Unit tests.
TUF spec requires client to check key ID calculation. Due to backward compatibility, instead of giving error when an incorrect key ID is found, we simply ignore that key. Tested: Unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only verify one signature for one key_id, otherwise an
attacker owning one key could simply duplicate one valid signature
and thus increasing the number of signatures that are valid. This
bypass the limitation of threshold.
Tested: Unit tests.