Deprecate retries config opt in favor of retry
#422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <bdehamer@github.com>
feelepxyz
reviewed
Aug 18, 2023
| @@ -7,7 +23,6 @@ export const defaultConfig = { | |||
| targetsMaxLength: 5000000, // bytes | |||
| prefixTargetsWithHash: true, | |||
| fetchTimeout: 100000, // milliseconds | |||
| fetchRetries: 2, | |||
| fetchRetries: undefined, | |||
There was a problem hiding this comment.
Any reason we don't just cut this option in 2.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
Configtype (exposed via theUpdaterOptionsinterface) to have a newfetchRetryoption which supersedes thefetchRetriesoption.Whereas
fetchRetriesonly accepted a numeric value (the number of times to retry the request),fetchRetryaccepts all of the options supported by the retry library which allows for more sophisticated strategies like exponential back-off.Setting
fetchRetryis still supported, but this option may be removed in a future release.