Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with missing port on both Windows and Linux #48

Closed
maacl opened this issue Oct 30, 2022 · 2 comments · Fixed by #49
Closed

Fails with missing port on both Windows and Linux #48

maacl opened this issue Oct 30, 2022 · 2 comments · Fixed by #49
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maacl
Copy link

maacl commented Oct 30, 2022

Following README starting soul fails on both Windows and Linux as follows:

❯ soul -d sqlite.db -p 8000
/mnt/c/Users/marti/AppData/Roaming/npm/node_modules/soul-cli/soul/config/index.js:32
  throw new Error(`Config validation error: ${error.message}`);
  ^

Error: Config validation error: "PORT" is required
@thevahidal thevahidal self-assigned this Oct 30, 2022
@thevahidal thevahidal added the bug Something isn't working label Oct 30, 2022
@thevahidal thevahidal added this to the hn-demo milestone Oct 30, 2022
@thevahidal
Copy link
Owner

Hi @maacl,
Thanks for testing Soul.
I checked it out and the problem was that the config was not considering CLI args while validating.
I fixed it and i'll merge to main.
You need to install the new version (v0.0.3).

@maacl
Copy link
Author

maacl commented Oct 30, 2022

Thanks. After upgrade it fails with:

PS C:\Users\marti\tmp\soul-test> soul -port 8080 -d sakila.db
C:\Users\marti\AppData\Roaming\npm\node_modules\soul-cli\src\config\index.js:43
  throw new Error(`Config validation error: ${error.message}`);
  ^

Error: Config validation error: "NODE_ENV" is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants