chore(lint): minor improvements (#13)

.golangci.yml

@@ -24,6 +24,11 @@ linters:
     - exhaustive
     - gocyclo
     - gomnd
+    - errorlint
+    - nlreturn
+    - forcetypeassert
+    - godox
+    - godot
 
 linters-settings:
   govet:

pkg/client/token.go

@@ -23,7 +23,6 @@ type Token struct {
 	Name   string `json:"name"`
 	Type   string `json:"type"`
 	Origin string `json:"origin"`
-	// TODO scopes
 }
 
 type DeleteAuthTokenRequest struct {

pkg/client/token_test.go

@@ -11,7 +11,11 @@ import (
 )
 
 func TestCreateDeleteToken(t *testing.T) {
+	t.Parallel()
+
 	recordHelper(t, "auth_token", func(ctx context.Context, t *testing.T, rec *recorder.Recorder, c *Client) {
+		t.Helper()
+
 		require.NotNil(t, c.httpClient)
 		pfx := "vault-plugin-secrets-vercel-fixtures-token"
 		ts := time.Now().UnixNano()

pkg/plugin/backend.go

@@ -17,14 +17,12 @@ Vercel Secrets backend is a secrets backend for dynamically managing Vercel toke
 `
 )
 
-// backend wraps the backend framework and adds a map for storing key value pairs
 type backend struct {
 	*framework.Backend
 }
 
 var _ logical.Factory = Factory
 
-// Factory configures and returns the backend
 func Factory(ctx context.Context, conf *logical.BackendConfig) (logical.Backend, error) {
 	b := newBackend()
 

pkg/plugin/backend_test.go

@@ -51,11 +51,14 @@ func newTestBackend(t *testing.T) (*backend, logical.Storage) {
 	config := logical.TestBackendConfig()
 	config.StorageView = new(logical.InmemStorage)
 	config.Logger = hclog.NewNullLogger()
-	b, err := Factory(context.Background(), config)
+	br, err := Factory(context.Background(), config)
 	require.NoError(t, err)
-	require.NotNil(t, b)
+	require.NotNil(t, br)
 
-	return b.(*backend), config.StorageView
+	b, ok := br.(*backend)
+	require.Equal(t, ok, true)
+
+	return b, config.StorageView
 }
 
 func TestBackend_Config(t *testing.T) {

pkg/plugin/path_config.go

@@ -89,6 +89,7 @@ func (b *backend) pathConfigWrite(ctx context.Context, req *logical.Request,
 		config.APIKey, ok = v.(string)
 		if !ok {
 			b.Logger().Trace("type assertion failed: %+v", v)
+
 			return nil, errTypeAssertionFailed
 		}
 	}
@@ -97,6 +98,7 @@ func (b *backend) pathConfigWrite(ctx context.Context, req *logical.Request,
 		config.BaseURL, ok = v.(string)
 		if !ok {
 			b.Logger().Trace("type assertion failed: %+v", v)
+
 			return nil, errTypeAssertionFailed
 		}
 	}
@@ -105,6 +107,7 @@ func (b *backend) pathConfigWrite(ctx context.Context, req *logical.Request,
 		v, ta := vr.(int)
 		if !ta {
 			b.Logger().Trace("type assertion failed: %+v", v)
+
 			return nil, errTypeAssertionFailed
 		}
 

pkg/plugin/path_token.go

@@ -68,6 +68,7 @@ func (b *backend) pathTokenWrite(ctx context.Context, req *logical.Request,
 		v, ta := vr.(int)
 		if !ta {
 			b.Logger().Trace("type assertion failed: %+v", v)
+
 			return nil, errTypeAssertionFailed
 		}
 

pkg/plugin/revoke.go

@@ -29,13 +29,15 @@ func (b *backend) Revoke(ctx context.Context, req *logical.Request, _ *framework
 	ks, ok := k.(string)
 	if !ok {
 		b.Logger().Trace("type assertion failed: %+v", ks)
+
 		return nil, errTypeAssertionFailed
 	}
 
 	_, err = svc.DeleteAuthToken(ctx, ks)
 	if err != nil {
 		b.Logger().Error("token delete failed: %s", err)
-		return nil, fmt.Errorf("failed to delete token: %s", err)
+
+		return nil, fmt.Errorf("failed to delete token: %w", err)
 	}
 
 	return &logical.Response{}, nil

pkg/service/service_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+//nolint:paralleltest
 func TestIntegration_Token(t *testing.T) {
 	if os.Getenv("ACC_TEST") == "" {
 		t.Skip("test skipped as ACC_TEST environment variable is not set")