Define part in 5b6 #1062
Merged
Define part in 5b6 #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarron
reviewed
Oct 19, 2022
|
I think there is another ambiguity here: if a center pieces pops on a stickerless cube, and the cap seperates from the stem, this should be considered one colored face, but it could be understood as two. It needs to be made clear that only colored faces that matter for the solved state should be counted. |
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
ohexter
reviewed
Nov 17, 2022
29 tasks
Co-authored-by: ohexter <116421789+ohexter@users.noreply.github.com>
centre -> center
CarterKoala
approved these changes
Dec 25, 2022
CarterKoala
added a commit
that referenced
this pull request
Dec 27, 2022
This reverts commit f5d19c6.
Nevseros
pushed a commit
that referenced
this pull request
Jan 31, 2023
Copied directly from the style guide, probably needs rewording/rethinking Also perhaps `piece` needs to be defined somewhere else as well? Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org> Co-authored-by: ohexter <116421789+ohexter@users.noreply.github.com> Co-authored-by: Carter Kucala <42009313+CarterKoala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied directly from the style guide, probably needs rewording/rethinking
Also perhaps
pieceneeds to be defined somewhere else as well?