Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of move #1073

Merged
merged 11 commits into from Dec 2, 2022
Merged

Definition of move #1073

merged 11 commits into from Dec 2, 2022

Conversation

Nanush7
Copy link
Member

@Nanush7 Nanush7 commented Oct 30, 2022

Added definition in 12i.
Modified regulations A3c1, B3c, B4b, A6e and A6b. (Note that A3c1, B3c and B4b are different to A6e and A6b)

@Nanush7 Nanush7 self-assigned this Oct 30, 2022
wca-regulations.md Outdated Show resolved Hide resolved
wca-regulations.md Outdated Show resolved Hide resolved
@Nanush7 Nanush7 marked this pull request as ready for review October 30, 2022 17:11
@Nanush7 Nanush7 requested a review from a team as a code owner October 30, 2022 17:11
@Nanush7 Nanush7 requested a review from Rouxles October 30, 2022 17:11
@Randomno
Copy link

Exception: If no moves, including any kind of alignment

I don't think this makes sense, since it suggests alignments are included in moves, when not all of them are.

As a whole, "alignment" is generally taken to mean arranging in a straight line. So these "any intentional alignment" regs seem more like they should say "intentional misalignment" or perhaps "change in alignment".

Also, A3c2 somewhat contradicts A3c1 now, so an exception could be clarified.

@Nanush7
Copy link
Member Author

Nanush7 commented Oct 31, 2022

it suggests alignments are included in moves, when not all of them are

Could you please elaborate a bit further? The definition of move is given in 12i, where moves are only considered to be "whole face turns" and misalignments beyond the limits of 10f. In this case, we don't want the competitor to even apply a single 1° of turn. However, I agree "change in alignment" may be better.

Copy link
Member Author

@Nanush7 Nanush7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Randomno Please review again

@Randomno
Copy link

Looks good, thank you. One point, I think this way of adding an exception is different to anywhere else in the regs. Normally it would either be like "Exception: see regulation A3c2", or A3c2 would become A3c1a.

To try to clarify, as I understand it, the phrase "x, including y" indicates that y is a subset of x. The only reason the add the "including" clause is for clarity. In the case of A6c, alignments are not a subset of moves, as you can have changes in alignment that do not constitute a move.

All I really have in mind is something like If no moves, nor any change in alignment, or If no changes in alignment, including moves. But that's my thought process behind it, if it makes sense.

@xsrvmy
Copy link

xsrvmy commented Nov 7, 2022

I have two concerns:

  1. Adding alignments to A6c and A6e makes it much more likely that one of these will result in a DNF. If the purpose of the reg is to preserve state then alignment shouldn't matter. If there is a borderline +2 then that would be a move anyways.
  2. BLD blindfold donning and very small misalignments could lead to frame by frame analysis of videos.

@Nanush7
Copy link
Member Author

Nanush7 commented Nov 7, 2022

@xsrvmy Thank you for your comments.

  1. I will think about it.
  2. The WRC has the internal policy to not to review videos frame by frame, so you shouldn't worry about it.

wca-regulations.md Outdated Show resolved Hide resolved
wca-regulations.md Outdated Show resolved Hide resolved
Nanush7 and others added 2 commits November 10, 2022 13:48
Co-authored-by: Antonio Kam <19kamh3@gmail.com>
Co-authored-by: Antonio Kam <19kamh3@gmail.com>
Copy link
Member

@lgarron lgarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are fairly well worded, apart from a few nits.

wca-regulations.md Outdated Show resolved Hide resolved
wca-regulations.md Outdated Show resolved Hide resolved
wca-regulations.md Outdated Show resolved Hide resolved
wca-regulations.md Outdated Show resolved Hide resolved
Rouxles and others added 5 commits December 1, 2022 00:03
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Co-authored-by: Antonio Kam <19kamh3@gmail.com>
@Nanush7
Copy link
Member Author

Nanush7 commented Dec 1, 2022

Fixed merge conflicts. Please, review again.

@Nanush7 Nanush7 requested a review from Rouxles December 1, 2022 23:45
Copy link
Contributor

@Rouxles Rouxles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the change above

wca-regulations.md Show resolved Hide resolved
@Rouxles Rouxles merged commit e2530fc into draft Dec 2, 2022
@Rouxles Rouxles deleted the clarify-move branch December 2, 2022 07:29
@xsrvmy
Copy link

xsrvmy commented Dec 3, 2022

Possible bug: under the current wording it seems like the competitor is not allowed to fix accidental misalignments.

@Nanush7 Nanush7 restored the clarify-move branch December 3, 2022 13:46
@lgarron lgarron deleted the clarify-move branch December 3, 2022 23:57
Nevseros pushed a commit that referenced this pull request Jan 31, 2023
Added definition in 12i.
Modified regulations A3c1, B3c, B4b, A6e and A6b. (Note that A3c1, B3c
and B4b are different to A6e and A6b)

Co-authored-by: Antonio Kam <19kamh3@gmail.com>
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants