New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of move #1073
Definition of move #1073
Conversation
I don't think this makes sense, since it suggests alignments are included in moves, when not all of them are. As a whole, "alignment" is generally taken to mean arranging in a straight line. So these "any intentional alignment" regs seem more like they should say "intentional misalignment" or perhaps "change in alignment". Also, A3c2 somewhat contradicts A3c1 now, so an exception could be clarified. |
Could you please elaborate a bit further? The definition of move is given in 12i, where moves are only considered to be "whole face turns" and misalignments beyond the limits of 10f. In this case, we don't want the competitor to even apply a single 1° of turn. However, I agree "change in alignment" may be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Randomno Please review again
Looks good, thank you. One point, I think this way of adding an exception is different to anywhere else in the regs. Normally it would either be like "Exception: see regulation A3c2", or A3c2 would become A3c1a. To try to clarify, as I understand it, the phrase "x, including y" indicates that y is a subset of x. The only reason the add the "including" clause is for clarity. In the case of A6c, alignments are not a subset of moves, as you can have changes in alignment that do not constitute a move. All I really have in mind is something like |
I have two concerns:
|
@xsrvmy Thank you for your comments.
|
Co-authored-by: Antonio Kam <19kamh3@gmail.com>
Co-authored-by: Antonio Kam <19kamh3@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes are fairly well worded, apart from a few nits.
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Co-authored-by: Antonio Kam <19kamh3@gmail.com>
Fixed merge conflicts. Please, review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the change above
Possible bug: under the current wording it seems like the competitor is not allowed to fix accidental misalignments. |
Added definition in 12i. Modified regulations A3c1, B3c, B4b, A6e and A6b. (Note that A3c1, B3c and B4b are different to A6e and A6b) Co-authored-by: Antonio Kam <19kamh3@gmail.com> Co-authored-by: Lucas Garron <lgarron@worldcubeassociation.org>
Added definition in 12i.
Modified regulations A3c1, B3c, B4b, A6e and A6b. (Note that A3c1, B3c and B4b are different to A6e and A6b)