New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only load google maps api when needed #232

Closed

jfly opened this issue Nov 19, 2015 · 1 comment · Fixed by #3025

Contributor

jfly commented Nov 19, 2015

Right now, we unconditionally include it on every page, which @Baiqiang says is quite a pain in China.

Alternatively/additionally, It seems like it would make sense to load the google maps api asynchronously. See https://developers.google.com/maps/documentation/javascript/tutorial#Loading_the_Maps_API and http://stackoverflow.com/questions/12419063/google-maps-differences-between-async-loading-and-general-script-tag.

@Baiqiang, what do you think?

jfly added the performance label

viroulep mentioned this issue

Drop Google Maps for Open Street Map #3025

Merged

Contributor Author

jfly commented Jul 7, 2018

For the record, the "conditionally include gmaps" was implemented in jfly@b46f638 as part of #434.

@viroulep, I'm going to go ahead and close this issue. Feel free to create a new one for dropping google maps entirely.

jfly closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment