Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning about submitting results #3222

Closed
Goosly opened this issue Aug 13, 2018 · 2 comments · Fixed by #3127
Closed

Incorrect warning about submitting results #3222

Goosly opened this issue Aug 13, 2018 · 2 comments · Fixed by #3127
Assignees
Labels
TEAM: wrt issues related to WRT

Comments

@Goosly
Copy link
Contributor

Goosly commented Aug 13, 2018

As a delegate, after I just submitted results, I still get this warning on the competition page:
"Note: Please submit results for this competition! You can upload them here."
And I also still have a notification about it.

This is incorrect and should be changed to something that makes clear that the results have been submitted, but the Results team hasn't published them yet. This way a delegate won't submit results twice, by accident.

I should also not be able to edit/fill in the submit-results-page when I've already submitted results.

@jfly jfly added this to To do in [BACKLOG] High priority results team work via automation Aug 21, 2018
@jfly
Copy link
Contributor

jfly commented Aug 21, 2018

@viroulep, do we have a plan for preventing/detecting if results have been submitted, but not yet uploaded?

@viroulep
Copy link
Member

I believe it will be taken care of in #3127, I've adjusted the user_should_post_competition_results? here, and used it to issue the warning on the competition page.

@viroulep viroulep self-assigned this Aug 22, 2018
@viroulep viroulep moved this from To do to In progress in [BACKLOG] High priority results team work Aug 22, 2018
[BACKLOG] High priority results team work automation moved this from In progress to Done Jan 26, 2019
@dunkOnIT dunkOnIT added the TEAM: wrt issues related to WRT label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEAM: wrt issues related to WRT
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants