Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%{short_name_limit} not being passed in new Competition Form #9410

Closed
dunkOnIT opened this issue May 23, 2024 · 1 comment
Closed

%{short_name_limit} not being passed in new Competition Form #9410

dunkOnIT opened this issue May 23, 2024 · 1 comment
Assignees
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo TECH: reactJS Requires knowledge of React

Comments

@dunkOnIT
Copy link
Contributor

dunkOnIT commented May 23, 2024

See screenshot below for an example of this issue (halfway through the sentence at the bottom of the picture):
image

My suspicion is that the React Competition Form is rendering the i18n string but not passing in the variable value it expects. Should be a straightforward change to how the i18n string is invoked - and I'm pretty sure short_name_limit should be 32 characters*.

*This can probably be confirmed by grepping the repo for variants of short_name_limit - it's probably defined in the backend somewhere

@dunkOnIT dunkOnIT added META: good first issue Small/easy change which is a good introduction to working in the WCA repo TECH: reactJS Requires knowledge of React labels May 23, 2024
@simonkellly simonkellly self-assigned this Jun 12, 2024
@lnzainn
Copy link
Contributor

lnzainn commented Jun 24, 2024

@dunkOnIT you can close this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo TECH: reactJS Requires knowledge of React
Projects
None yet
Development

No branches or pull requests

3 participants