Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-BR translation #132

Merged
merged 7 commits into from
Jun 23, 2024
Merged

pt-BR translation #132

merged 7 commits into from
Jun 23, 2024

Conversation

josemoura212
Copy link
Contributor

No description provided.

@josemoura212
Copy link
Contributor Author

translation update

@thewh1teagle
Copy link
Owner

Hey @josemoura212,

I hope you’re doing well!

I’ve just resolved the git conflicts with the main branch, so everything is now up to date. Additionally, I’ve added the i18n configuration for pt-BR, so that language option will be available on the website.

Regarding the addition of a pt-BR README.md: In the long term, maintaining multiple translations could become burdensome, especially as we might need to add other languages too. Users can usually read the English version, so I believe it’s more efficient to stick with a single version for now.

As for listing available languages in the README.md, I think it’s a great idea to include this information, but perhaps we could place it somewhere other than the headline. Do you have any suggestions on where it might fit best?

Thank you so much for your continued contributions!

@josemoura212
Copy link
Contributor Author

josemoura212 commented Jun 23, 2024

@thewh1teagle

In fact, the translations in addition to the README have another installation guide, I had thought about creating a 'translations' folder and separating the other languages ​​into subfolders thus containing all the translated .MD files

example:

translations
    |
    |
    pt-BR
             |
             file.md

I didn't have time to implement

@thewh1teagle
Copy link
Owner

@josemoura212

I appreciate the effort to make documentation more accessible. However, to maintain a streamlined and manageable approach to the documentation in the long term, I would prefer not to add translations directly to the README.md.

Currently, we provide translations on the website, which should cater to most users, and GitHub users generally have a good understanding of English. This helps keep the README concise and focused on its primary purpose.

If you're okay with it, I can remove the proposed changes from the PR and proceed with merging the rest. Let me know how you'd like to proceed. thanks :)

@josemoura212
Copy link
Contributor Author

@thewh1teagle

You can proceed without README.md

@thewh1teagle thewh1teagle merged commit 891ad88 into thewh1teagle:main Jun 23, 2024
2 of 3 checks passed
@thewh1teagle
Copy link
Owner

Merged. the language is already available in the website, let me know if it shown as Portuguese for you.

@josemoura212
Copy link
Contributor Author

josemoura212 commented Jun 23, 2024

It worked on the anonymous page, now it is translated, it was in cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants