Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when Puli class is a FQCN #1

Merged
merged 1 commit into from May 22, 2016
Merged

Fix when Puli class is a FQCN #1

merged 1 commit into from May 22, 2016

Conversation

magnusnordlander
Copy link

Turned out the problem was that the generated stub did not have a namespace.

@magnusnordlander magnusnordlander mentioned this pull request May 7, 2016
Merged
@thewilkybarkid
Copy link
Owner

Good catch. We should also fix testCreatesStubFactoryClassIfDoesNotExist, which is actually broken (with separate tests for a namespaced and non-namespaced class).

@thewilkybarkid thewilkybarkid merged commit f269b92 into thewilkybarkid:classmap May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@magnusnordlander @thewilkybarkid