Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make itk.ants_registration have the same API and behavior as ants.registration #2

Closed
thewtex opened this issue Jan 8, 2024 · 3 comments · Fixed by #21
Closed

make itk.ants_registration have the same API and behavior as ants.registration #2

thewtex opened this issue Jan 8, 2024 · 3 comments · Fixed by #21
Assignees

Comments

@thewtex
Copy link
Owner

thewtex commented Jan 8, 2024

Ref: https://antspyx.readthedocs.io/en/latest/registration.html

The wrapping of itk.ANTSRegistration, itk.ants_registration, should have a similar API and behavior as antspy ants.registration.

First add tests following the ANTs tests for just all the C++ interfaces, options and behavior.

Then add the corresponding Python tests.

@dzenanz
Copy link
Collaborator

dzenanz commented Jan 15, 2024

Which ANTs files should we include and invoke from https://github.com/thewtex/ANTsWasm/blob/main/include/itkANTSRegistration.hxx? There are many abstraction layers in ANTs. ANTsPy code is not helpful there.

@dzenanz
Copy link
Collaborator

dzenanz commented Jan 16, 2024

My WIP is coming up with:

CMake Error at CMakeLists.txt:39 (find_package):
  By not providing "FindANTS.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "ANTS", but
  CMake did not find one.

  Could not find a package configuration file provided by "ANTS" with any of
  the following names:

    ANTSConfig.cmake
    ants-config.cmake

The easiest path forward seems to be to resolve ANTsX/ANTs#1369.

@dzenanz
Copy link
Collaborator

dzenanz commented Jan 16, 2024

With main running into:

itkANTSRegistration: warning(4): ITK type not wrapped, or currently not known: itk::DataObjectDecorator< itk::CompositeTransform< double, 2 > >
itkANTSRegistration: warning(4): ITK type not wrapped, or currently not known: itk::DataObjectDecorator< itk::CompositeTransform< double, 3 > >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants