Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE Files to Identify ANTs Libraries #1369

Open
blakedewey opened this issue May 27, 2022 · 8 comments
Open

CMAKE Files to Identify ANTs Libraries #1369

blakedewey opened this issue May 27, 2022 · 8 comments
Labels
feature request Ideas for new or improved ANTs features help needed Issues that require feedback or expertise from the community. Discussion and PRs welcome

Comments

@blakedewey
Copy link

Is your feature request related to a problem?
Building something like ANTsPy on top of an ANTs installation is difficult because ANTs libraries aren't defined in a CMAKE file that can be found using find_package.

Proposed new features
Generate a ANTsConfig.cmake file (at the minimum) that defines the libraries installed with ANTs.

@cookpa cookpa added help needed Issues that require feedback or expertise from the community. Discussion and PRs welcome feature request Ideas for new or improved ANTs features labels May 31, 2022
@dzenanz
Copy link
Contributor

dzenanz commented Jan 11, 2024

Was any progress made on this front?

@cookpa
Copy link
Member

cookpa commented Jan 11, 2024

Not to my knowledge, sorry

@dzenanz
Copy link
Contributor

dzenanz commented Jan 16, 2024

I think I need to do this. Can this issue be assigned to me?

@cookpa
Copy link
Member

cookpa commented Jan 16, 2024

Certainly, that would be great. Happy to help if I can

dzenanz added a commit to dzenanz/ANTs that referenced this issue Jan 16, 2024
@dzenanz
Copy link
Contributor

dzenanz commented Jan 16, 2024

It turns out I don't need this, at least not now. I made minimal progress, which I put in draft PR #1656.

@dzenanz dzenanz removed their assignment Jan 16, 2024
@ncullen93
Copy link
Member

Hi @dzenanz just curious - why did you not need this in the end? The biggest enhancement for ANTsPy would be to prune unused files from the ANTs build in order to decrease the build size, so I am wondering if your draft PR was progress towards that front. Thanks!

@dzenanz
Copy link
Contributor

dzenanz commented Feb 23, 2024

I ended up not compiling ANTs as such. I FetchContent, specify its include directories, and use (some of) the headers. See the details here:
https://github.com/thewtex/ANTsWasm/blob/main/CMakeLists.txt

@ncullen93
Copy link
Member

Got it - looks interesting, thanks for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas for new or improved ANTs features help needed Issues that require feedback or expertise from the community. Discussion and PRs welcome
Projects
None yet
Development

No branches or pull requests

4 participants